summaryrefslogtreecommitdiffstats
path: root/HACKING
diff options
context:
space:
mode:
authorDave Reisner <dreisner@archlinux.org>2011-12-18 03:42:35 +0100
committerDan McGee <dan@archlinux.org>2011-12-22 01:13:17 +0100
commitd6ccd4439044978a6dcc01b8c1ab880b6164f9d1 (patch)
treeba8360f6e0177fa9ad13d1b794a21cae00bdbc01 /HACKING
parent6c1426842af7de1343b8360e2d0ca52846ea4a2f (diff)
downloadpacman-d6ccd4439044978a6dcc01b8c1ab880b6164f9d1.tar.gz
pacman-d6ccd4439044978a6dcc01b8c1ab880b6164f9d1.tar.xz
include config.h via Makefiles
Ensures that config.h is always ordered correctly (first) in the includes. Also means that new source files get this for free without having to remember to add it. We opt for -imacros over -include as its more portable, and the added constraint by -imacros doesn't bother us for config.h. This also touches the HACKING file to remove the explicit mention of config.h as part of the includes. Signed-off-by: Dave Reisner <dreisner@archlinux.org> Signed-off-by: Dan McGee <dan@archlinux.org>
Diffstat (limited to 'HACKING')
-rw-r--r--HACKING4
1 files changed, 2 insertions, 2 deletions
diff --git a/HACKING b/HACKING
index e829e5d7..8a59344e 100644
--- a/HACKING
+++ b/HACKING
@@ -114,8 +114,6 @@ general pattern, including blank lines:
[source,C]
-------------------------------------------
-#include "config.h"
-
#include <standardheader.h>
#include <another.h>
#include <...>
@@ -144,6 +142,8 @@ For pacman:
#include "anythingelse.h"
-------------------------------------------
+Never directly include config.h. This will always be added via Makefiles.
+
GDB and Valgrind Usage
~~~~~~~~~~~~~~~~~~~~~~