diff options
| author | Nagy Gabor <ngaba@bibl.u-szeged.hu> | 2008-07-15 13:30:34 +0200 |
|---|---|---|
| committer | Dan McGee <dan@archlinux.org> | 2008-07-16 02:13:30 +0200 |
| commit | 37b5972212f9e5d08b28a47f2990ba2b102056da (patch) | |
| tree | 95e6d6409e729ef8e4fded08a1fbfee6f6264ddc /lib/libalpm/add.c | |
| parent | 17e9c9d9ff8b10f4fd82ba17ea968e071a273482 (diff) | |
| download | pacman-37b5972212f9e5d08b28a47f2990ba2b102056da.tar.gz pacman-37b5972212f9e5d08b28a47f2990ba2b102056da.tar.xz | |
Fix some memleaks in alpm/add.c
In case of error some allocated memory wasn't freed in commit_single_pkg.
Note: The return value of this function is not used.
Signed-off-by: Nagy Gabor <ngaba@bibl.u-szeged.hu>
Signed-off-by: Dan McGee <dan@archlinux.org>
Diffstat (limited to 'lib/libalpm/add.c')
| -rw-r--r-- | lib/libalpm/add.c | 20 |
1 files changed, 13 insertions, 7 deletions
diff --git a/lib/libalpm/add.c b/lib/libalpm/add.c index b2f68805..72ea70c0 100644 --- a/lib/libalpm/add.c +++ b/lib/libalpm/add.c @@ -689,7 +689,7 @@ static int commit_single_pkg(pmpkg_t *newpkg, int pkg_current, int pkg_count, /* set up fake remove transaction */ int ret = upgrade_remove(oldpkg, newpkg, trans, db); if(ret != 0) { - return(ret); + goto cleanup; } } @@ -701,7 +701,9 @@ static int commit_single_pkg(pmpkg_t *newpkg, int pkg_current, int pkg_count, _alpm_log(PM_LOG_DEBUG, "extracting files\n"); if ((archive = archive_read_new()) == NULL) { - RET_ERR(PM_ERR_LIBARCHIVE, -1); + pm_errno = PM_ERR_LIBARCHIVE; + ret = -1; + goto cleanup; } archive_read_support_compression_all(archive); @@ -710,7 +712,9 @@ static int commit_single_pkg(pmpkg_t *newpkg, int pkg_current, int pkg_count, _alpm_log(PM_LOG_DEBUG, "archive: %s\n", newpkg->origin_data.file); if(archive_read_open_filename(archive, newpkg->origin_data.file, ARCHIVE_DEFAULT_BYTES_PER_BLOCK) != ARCHIVE_OK) { - RET_ERR(PM_ERR_PKG_OPEN, -1); + pm_errno = PM_ERR_PKG_OPEN; + ret = -1; + goto cleanup; } /* save the cwd so we can restore it later */ @@ -772,7 +776,7 @@ static int commit_single_pkg(pmpkg_t *newpkg, int pkg_current, int pkg_count, } if(errors) { - ret = 1; + ret = -1; if(is_upgrade) { _alpm_log(PM_LOG_ERROR, _("problem occurred while upgrading %s\n"), newpkg->name); @@ -798,7 +802,9 @@ static int commit_single_pkg(pmpkg_t *newpkg, int pkg_current, int pkg_count, alpm_pkg_get_name(newpkg), alpm_pkg_get_version(newpkg)); alpm_logaction("error: could not update database entry %s-%s\n", alpm_pkg_get_name(newpkg), alpm_pkg_get_version(newpkg)); - RET_ERR(PM_ERR_DB_WRITE, -1); + pm_errno = PM_ERR_DB_WRITE; + ret = -1; + goto cleanup; } if(_alpm_db_add_pkgincache(db, newpkg) == -1) { @@ -833,9 +839,9 @@ static int commit_single_pkg(pmpkg_t *newpkg, int pkg_current, int pkg_count, EVENT(trans, PM_TRANS_EVT_ADD_DONE, newpkg, oldpkg); } +cleanup: _alpm_pkg_free(oldpkg); - - return(0); + return(ret); } int _alpm_add_commit(pmtrans_t *trans, pmdb_t *db) |