diff options
| author | Dan McGee <dan@archlinux.org> | 2008-03-23 21:28:48 +0100 |
|---|---|---|
| committer | Dan McGee <dan@archlinux.org> | 2008-03-23 22:55:52 +0100 |
| commit | 1086950c82ab649ffc36a00cd8d343da376252fe (patch) | |
| tree | ea3298b195122e928e10a1ea2f527e6577c3fe80 /lib/libalpm/backup.c | |
| parent | 7995a25d0ed75968df72fcf65d231508417ec060 (diff) | |
| download | pacman-1086950c82ab649ffc36a00cd8d343da376252fe.tar.gz pacman-1086950c82ab649ffc36a00cd8d343da376252fe.tar.xz | |
memleak fix: ensure backup fname isn't lost if unused
The _alpm_backup_split function always alloced memory for the fname, and we
let it disappear in a specific case (upgrade026.py). Fix the issue.
Signed-off-by: Dan McGee <dan@archlinux.org>
Diffstat (limited to 'lib/libalpm/backup.c')
| -rw-r--r-- | lib/libalpm/backup.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/lib/libalpm/backup.c b/lib/libalpm/backup.c index bedbe8c1..f89df55e 100644 --- a/lib/libalpm/backup.c +++ b/lib/libalpm/backup.c @@ -42,6 +42,9 @@ int _alpm_backup_split(const char *string, char **file, char **hash) if(ptr == NULL) { if(file) { *file = str; + } else { + /* don't need our dup as the fname wasn't requested, so free it */ + FREE(str); } return(0); } |