diff options
| author | Dan McGee <dan@archlinux.org> | 2011-08-29 19:12:54 +0200 |
|---|---|---|
| committer | Dan McGee <dan@archlinux.org> | 2011-08-30 02:57:05 +0200 |
| commit | 234b6ffc2c39268d1efdc414e02bc4b352e5d931 (patch) | |
| tree | f01da20df830137e3954631e93a5ce698b310109 /lib/libalpm/be_package.c | |
| parent | d74dad79b7770725090e1eb2a015cbd6f88aed66 (diff) | |
| download | pacman-234b6ffc2c39268d1efdc414e02bc4b352e5d931.tar.gz pacman-234b6ffc2c39268d1efdc414e02bc4b352e5d931.tar.xz | |
Parse > 2GiB file sizes correctly
We were using atol(), which on 32 bit, cannot handle values greater than
2GiB, which is fail.
Switch to a strtoull() wrapper function tailored toward parsing off_t
values. This allows parsing of very large positive integer values. off_t
is a signed type, but in our usages, we never parse or have a need for
negative values, so the function will return -1 on error.
Before:
$ pacman -Si flightgear-data | grep Size
Download Size : 2097152.00 K
Installed Size : 2097152.00 K
After:
$ ./src/pacman/pacman -Si flightgear-data | grep Size
Download Size : 2312592.52 KiB
Installed Size : 5402896.00 KiB
Signed-off-by: Dan McGee <dan@archlinux.org>
Diffstat (limited to 'lib/libalpm/be_package.c')
| -rw-r--r-- | lib/libalpm/be_package.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/libalpm/be_package.c b/lib/libalpm/be_package.c index 0e58d20a..98a1240a 100644 --- a/lib/libalpm/be_package.c +++ b/lib/libalpm/be_package.c @@ -187,7 +187,7 @@ static int parse_descfile(alpm_handle_t *handle, struct archive *a, alpm_pkg_t * STRDUP(newpkg->arch, ptr, return -1); } else if(strcmp(key, "size") == 0) { /* size in the raw package is uncompressed (installed) size */ - newpkg->isize = atol(ptr); + newpkg->isize = _alpm_strtoofft(ptr); } else if(strcmp(key, "depend") == 0) { alpm_depend_t *dep = _alpm_splitdep(ptr); newpkg->depends = alpm_list_add(newpkg->depends, dep); |