diff options
| author | Dave Reisner <dreisner@archlinux.org> | 2019-12-24 16:28:11 +0100 |
|---|---|---|
| committer | Allan McRae <allan@archlinux.org> | 2020-01-07 02:40:32 +0100 |
| commit | 9883015be2b2010ad541fd02b6856bfdb28fb35d (patch) | |
| tree | cea21e7bc4eab89a47356f60c4b924ae3043bb42 /lib/libalpm/be_package.c | |
| parent | ffb69c700abd6eb3b86e79e09b135029ff9104b4 (diff) | |
| download | pacman-9883015be2b2010ad541fd02b6856bfdb28fb35d.tar.gz pacman-9883015be2b2010ad541fd02b6856bfdb28fb35d.tar.xz | |
Use c99 struct initialization to avoid memset calls
This is guaranteed less error prone than calling memset and hoping the
human gets the argument order correct.
Diffstat (limited to 'lib/libalpm/be_package.c')
| -rw-r--r-- | lib/libalpm/be_package.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/lib/libalpm/be_package.c b/lib/libalpm/be_package.c index 5ffea875..9a8b4410 100644 --- a/lib/libalpm/be_package.c +++ b/lib/libalpm/be_package.c @@ -164,9 +164,8 @@ static int parse_descfile(alpm_handle_t *handle, struct archive *a, alpm_pkg_t * char *ptr = NULL; char *key = NULL; int ret, linenum = 0; - struct archive_read_buffer buf; + struct archive_read_buffer buf = {0}; - memset(&buf, 0, sizeof(buf)); /* 512K for a line length seems reasonable */ buf.max_line_size = 512 * 1024; @@ -448,13 +447,11 @@ static int build_filelist_from_mtree(alpm_handle_t *handle, alpm_pkg_t *pkg, str char *mtree_data = NULL; struct archive *mtree; struct archive_entry *mtree_entry = NULL; - alpm_filelist_t filelist; + alpm_filelist_t filelist = {0}; _alpm_log(handle, ALPM_LOG_DEBUG, "found mtree for package %s, getting file list\n", pkg->filename); - memset(&filelist, 0, sizeof(alpm_filelist_t)); - /* create a new archive to parse the mtree and load it from archive into memory */ /* TODO: split this into a function */ if((mtree = archive_read_new()) == NULL) { |