summaryrefslogtreecommitdiffstats
path: root/lib/libalpm/be_sync.c
diff options
context:
space:
mode:
authorRikard Falkeborn <rikard.falkeborn@gmail.com>2016-09-22 20:00:00 +0200
committerAllan McRae <allan@archlinux.org>2016-09-25 09:32:20 +0200
commit85171807c15fb5907d8337af2a50ab79392e1b8c (patch)
tree1459ab339a2fd46097b7405f7423f7d06356d3d8 /lib/libalpm/be_sync.c
parent34f3f1e7a640488c4c32a3a825813afc1ad2ed68 (diff)
downloadpacman-85171807c15fb5907d8337af2a50ab79392e1b8c.tar.gz
pacman-85171807c15fb5907d8337af2a50ab79392e1b8c.tar.xz
Return boolean from db_populate
Since the number of packages is not used anywhere, just return a boolean to avoid the implicit cast from size_t to int in be_local.c. Use 0 as success to be consistent with db_validate. Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> Signed-off-by: Allan McRae <allan@archlinux.org>
Diffstat (limited to 'lib/libalpm/be_sync.c')
-rw-r--r--lib/libalpm/be_sync.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/lib/libalpm/be_sync.c b/lib/libalpm/be_sync.c
index 06f96199..3591e3f8 100644
--- a/lib/libalpm/be_sync.c
+++ b/lib/libalpm/be_sync.c
@@ -464,6 +464,7 @@ static int sync_db_populate(alpm_db_t *db)
const char *dbpath;
size_t est_count;
int count, fd;
+ int ret = 0;
struct stat buf;
struct archive *archive;
struct archive_entry *entry;
@@ -497,7 +498,7 @@ static int sync_db_populate(alpm_db_t *db)
db->pkgcache = _alpm_pkghash_create(est_count);
if(db->pkgcache == NULL) {
db->handle->pm_errno = ALPM_ERR_MEMORY;
- count = -1;
+ ret = -1;
goto cleanup;
}
@@ -530,7 +531,7 @@ cleanup:
if(fd >= 0) {
close(fd);
}
- return count;
+ return ret;
}
/* This function validates %FILENAME%. filename must be between 3 and