diff options
| author | Nagy Gabor <ngaba@bibl.u-szeged.hu> | 2008-08-24 23:24:53 +0200 |
|---|---|---|
| committer | Dan McGee <dan@archlinux.org> | 2009-01-13 05:44:00 +0100 |
| commit | a888f377a5c805f1da24b556e6a4a9e3678d8eb3 (patch) | |
| tree | 70ffd810a0b240429d2dfaa0d7266e228b6212f2 /src/pacman/remove.c | |
| parent | 8017b0bb8ec5364f8a3999caffc6b3c3ea991810 (diff) | |
| download | pacman-a888f377a5c805f1da24b556e6a4a9e3678d8eb3.tar.gz pacman-a888f377a5c805f1da24b556e6a4a9e3678d8eb3.tar.xz | |
HoldPkg rework
The HoldPkg feature is even more important when the packages to be held are
pulled automatically by pacman, in a -Rc and -Rs operation. Before, it only
applied when the packages were explicitly requested by the user to be
removed. This patch extends holdpkg to -Rc and -Rs by doing the HoldPkg
check just before trans_commit.
Additionally, the whole HoldPkg stuff was moved to the front-end.
I changed the default behavior to "don't remove", so I modified remove030.py
pactest as well.
See also: FS#9173.
Original-work-by: Xavier Chantry <shiningxc@gmail.com>
Signed-off-by: Nagy Gabor <ngaba@bibl.u-szeged.hu>
Signed-off-by: Dan McGee <dan@archlinux.org>
Diffstat (limited to 'src/pacman/remove.c')
| -rw-r--r-- | src/pacman/remove.c | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/src/pacman/remove.c b/src/pacman/remove.c index b70f7035..841a08bb 100644 --- a/src/pacman/remove.c +++ b/src/pacman/remove.c @@ -121,6 +121,21 @@ int pacman_remove(alpm_list_t *targets) goto cleanup; } + /* Search for holdpkg in target list */ + int holdpkg = 0; + for(i = alpm_trans_get_pkgs(); i; i = alpm_list_next(i)) { + pmpkg_t *pkg = alpm_list_getdata(i); + if(alpm_list_find_str(config->holdpkg, alpm_pkg_get_name(pkg))) { + pm_printf(PM_LOG_WARNING, _("%s is designated as a HoldPkg.\n"), + alpm_pkg_get_name(pkg)); + holdpkg = 1; + } + } + if(holdpkg && (noyes(_("HoldPkg was found in target list. Do you want to continue?")) == 0)) { + retval = 1; + goto cleanup; + } + /* Warn user in case of dangerous operation */ if(config->flags & PM_TRANS_FLAG_RECURSE || config->flags & PM_TRANS_FLAG_CASCADE) { |