diff options
| author | Allan McRae <allan@archlinux.org> | 2010-06-19 10:55:08 +0200 |
|---|---|---|
| committer | Allan McRae <allan@archlinux.org> | 2010-06-20 17:04:58 +0200 |
| commit | 59c47aaf529df02ec1577fe727c3c84d13592666 (patch) | |
| tree | 63049bcc89e7058376ce0607ddee116b2f819ddc /src/pacman/upgrade.c | |
| parent | d7dccd541962f0dd8bf323ae11633e595bfb4922 (diff) | |
| download | pacman-59c47aaf529df02ec1577fe727c3c84d13592666.tar.gz pacman-59c47aaf529df02ec1577fe727c3c84d13592666.tar.xz | |
Clarify testing within conditional statements
Follow the HACKING guidelines and always use != 0 or == 0 rather
than negation within conditional statements to improve clarity.
Most of these are !strcmp usages which is the example of what not
to do in the HACKING document.
Signed-off-by: Allan McRae <allan@archlinux.org>
Diffstat (limited to 'src/pacman/upgrade.c')
| -rw-r--r-- | src/pacman/upgrade.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/pacman/upgrade.c b/src/pacman/upgrade.c index 1442eb56..c9c8301f 100644 --- a/src/pacman/upgrade.c +++ b/src/pacman/upgrade.c @@ -112,7 +112,7 @@ int pacman_upgrade(alpm_list_t *targets) const char *package2 = alpm_conflict_get_package2(conflict); const char *reason = alpm_conflict_get_reason(conflict); /* only print reason if it contains new information */ - if(!strcmp(package1, reason) || !strcmp(package2, reason)) { + if(strcmp(package1, reason) == 0 || strcmp(package2, reason) == 0) { printf(_(":: %s and %s are in conflict\n"), package1, package2); } else { printf(_(":: %s and %s are in conflict (%s)\n"), package1, package2, reason); |