summaryrefslogtreecommitdiffstats
path: root/submitting-patches
diff options
context:
space:
mode:
Diffstat (limited to 'submitting-patches')
-rw-r--r--submitting-patches26
1 files changed, 25 insertions, 1 deletions
diff --git a/submitting-patches b/submitting-patches
index 78974458..0fe54ef6 100644
--- a/submitting-patches
+++ b/submitting-patches
@@ -27,6 +27,12 @@ Creating your patch:
Submitting your patch:
+* Send the patch to the pacman-dev mailing list
+
+ The mailing list is the primary queue for review and acceptance. Here you
+ will get feedback, and let me know the details of your patch. It also helps
+ if you add "[patch]" to the beginning of your Subject line.
+
* No MIME, no links, no compression, no attachments. Just plain text.
Patches should be contained in the actual body of the email. There are many
@@ -40,5 +46,23 @@ Submitting your patch:
* Describe your patch.
- TODO...
+ Before the actual diff begins, it helps if you describe the changes in the
+ patch. This allows others to see what you intended so as to compare it to
+ what was actually done, and allows better feedback
+
+* Credit yourself
+
+ Just like with the kernel, it helps if you add a "Signed Off By" line to
+ indicate who has "signed" the patch - who has approved it.
+
+ Signed-off-by: Aaron Griffin <aaron@archlinux.org>
+
+ Please use your real name and email address. Feel free to "scramble" the
+ address if you're afraid of spam.
+
+After you submit:
+
+* Don't get discouraged
+ Any feedback you get, positive or negative, has nothing to do with you. If a
+ patch is rejected, try taking the suggestions into account and re-submitting.