summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNiko Tyni <ntyni@iki.fi>2005-08-23 14:43:37 +0200
committerNiko Tyni <ntyni@iki.fi>2005-08-23 14:43:37 +0200
commit69064fb816bd54a08ffd92760f125a5d83793250 (patch)
treeabd6177d65654c5e2e0018937052b62e486d23f1
parent2f01fa7db139ec0141bf5e7f8d8e2223069d3c68 (diff)
downloadsmokeping-69064fb816bd54a08ffd92760f125a5d83793250.tar.gz
smokeping-69064fb816bd54a08ffd92760f125a5d83793250.tar.xz
* 2.0/lib/Smokeping.pm,
2.0/CHANGES: + make errors in DYNAMIC updates appear in the web server error log * 2.0/TODO: + replace the __WARN__ and __DIE__ handlers with CGI::Carp?
-rw-r--r--CHANGES2
-rw-r--r--TODO4
-rw-r--r--lib/Smokeping.pm3
3 files changed, 8 insertions, 1 deletions
diff --git a/CHANGES b/CHANGES
index d84524a..4d19be9 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,5 @@
+* make errors in DYNAMIC updates appear in the web server error log
+ -- niko
* remove a quotemeta() call in Config::Grammar to allow metacharacters
at the right side of '@define'
-- niko, reported by Warrick FitzGerald <lists.smokeping.wfitzgerald *crtman.com>
diff --git a/TODO b/TODO
index 282052e..5189180 100644
--- a/TODO
+++ b/TODO
@@ -40,3 +40,7 @@
configurable RRD parameters per target?
- suggested by Leos Bitto,
<http://lists.ee.ethz.ch/smokeping-users/msg01632.html>
+
+* CGI LOGGING
+ replace the __WARN__ and __DIE__ handlers with CGI::Carp?
+ Problems with speedy?
diff --git a/lib/Smokeping.pm b/lib/Smokeping.pm
index 5d28b78..8f98341 100644
--- a/lib/Smokeping.pm
+++ b/lib/Smokeping.pm
@@ -2572,7 +2572,8 @@ sub cgi ($) {
-charset=> ( $cfg->{Presentation}{charset} || 'iso-8859-15')
);
if ($q->param(-name=>'secret') && $q->param(-name=>'target') ) {
- update_dynaddr $cfg,$q;
+ my $ret = update_dynaddr $cfg,$q;
+ do_cgilog($ret) if defined $ret and $ret ne "";
} else {
display_webpage $cfg,$q;
}