summaryrefslogtreecommitdiffstats
path: root/lib/Smokeping/probes/EchoPing.pm
diff options
context:
space:
mode:
authorTobi Oetiker <tobi@oetiker.ch>2007-10-15 09:49:18 +0200
committerTobi Oetiker <tobi@oetiker.ch>2007-10-15 09:49:18 +0200
commit15ce7b9d28dda1afb6b892c1e2a34e057f3fdb60 (patch)
tree0226ecb3ea1595463dad24204ac65f9885c4d63b /lib/Smokeping/probes/EchoPing.pm
parent03d504e82b3e6c77c0b59af415ff740de1b483f3 (diff)
downloadsmokeping-15ce7b9d28dda1afb6b892c1e2a34e057f3fdb60.tar.gz
smokeping-15ce7b9d28dda1afb6b892c1e2a34e057f3fdb60.tar.xz
* fixed parsing of slaves statements in config file, broeken since I seemingly relaxed the hostname constraints.
* removed all online testing from Curl and EchoPing probes
Diffstat (limited to 'lib/Smokeping/probes/EchoPing.pm')
-rw-r--r--lib/Smokeping/probes/EchoPing.pm7
1 files changed, 4 insertions, 3 deletions
diff --git a/lib/Smokeping/probes/EchoPing.pm b/lib/Smokeping/probes/EchoPing.pm
index 4be5a0d..95d1a6e 100644
--- a/lib/Smokeping/probes/EchoPing.pm
+++ b/lib/Smokeping/probes/EchoPing.pm
@@ -88,15 +88,16 @@ sub test_usage {
my $arghashref = $self->features;
my %arghash = %$arghashref;
-
for my $feature (keys %arghash) {
- if (`$bin $arghash{$feature} 1 0.0.0.1 2>&1` =~ /invalid option|usage/i) {
+ # when the option is invalid, then echoping would
+ # complain. if it is valid, then it will just display
+ # the usage message.
+ if (`$bin $arghash{$feature} 2>&1` !~ /^Usage/i) {
push @unsupported, $feature;
$self->do_log("Note: your echoping doesn't support the $feature feature (option $arghash{$feature}), disabling it");
}
}
map { delete $arghashref->{$_} } @unsupported;
-
return;
}