summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorlpsolit%gmail.com <>2005-09-02 06:52:20 +0200
committerlpsolit%gmail.com <>2005-09-02 06:52:20 +0200
commit5432b26b7479c9b90c1e172d285f02c00c173870 (patch)
treeac9d741c9398aacf562b9c79eb0a848cb37e1ef8
parentde1f16178dcae2d517e849e45ee77fd3d636005c (diff)
downloadbugzilla-5432b26b7479c9b90c1e172d285f02c00c173870.tar.gz
bugzilla-5432b26b7479c9b90c1e172d285f02c00c173870.tar.xz
Bug 298306: For new products, the charting error message "The tool which gathers bug counts has not been run yet" is misleading - Patch by Marc Schumann <wurblzap@gmail.com> r=gerv a=myk
-rwxr-xr-xreports.cgi6
-rw-r--r--template/en/default/global/code-error.html.tmpl14
2 files changed, 17 insertions, 3 deletions
diff --git a/reports.cgi b/reports.cgi
index 49948e2bb..7274ea8e2 100755
--- a/reports.cgi
+++ b/reports.cgi
@@ -253,7 +253,11 @@ sub generate_chart {
my ($data_file, $image_file, $type, $product, $datasets) = @_;
if (! open FILE, $data_file) {
- ThrowCodeError("chart_data_not_generated");
+ if ($product eq '-All-') {
+ $product = '';
+ }
+
+ ThrowCodeError("chart_data_not_generated", {'product' => $product});
}
my @fields;
diff --git a/template/en/default/global/code-error.html.tmpl b/template/en/default/global/code-error.html.tmpl
index f11b27b0a..b459fa44a 100644
--- a/template/en/default/global/code-error.html.tmpl
+++ b/template/en/default/global/code-error.html.tmpl
@@ -70,8 +70,18 @@
the error [% bug.error FILTER html %].
[% ELSIF error == "chart_data_not_generated" %]
- The tool which gathers [% terms.bug %] counts has not been run yet.
-
+ [% IF product %]
+ Charts for the <em>[% product FILTER html %]</em> product are not
+ available yet because no charting data has been collected for it since it
+ was created.
+ [% ELSE %]
+ No charting data has been collected yet.
+ [% END %]
+ Please wait a day and try again.
+ If you're seeing this message after a day, then you should contact
+ <a href="mailto:[% Param('maintainer') %]">[% Param('maintainer') %]</a>
+ and reference this error.
+
[% ELSIF error == "chart_datafile_corrupt" %]
The chart data file [% file FILTER html %] is corrupt.