summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authormkanat%bugzilla.org <>2008-07-03 02:10:17 +0200
committermkanat%bugzilla.org <>2008-07-03 02:10:17 +0200
commitb446f4e4e5db1300c8ee9edea900c8e3456e8d1f (patch)
treea3e1dc1f8a3deb115f7416e3d544524de32994b4
parentf1f87e08fc375fd3195b1defa15e971b0b39a141 (diff)
downloadbugzilla-b446f4e4e5db1300c8ee9edea900c8e3456e8d1f.tar.gz
bugzilla-b446f4e4e5db1300c8ee9edea900c8e3456e8d1f.tar.xz
Bug 442821: Make the workflow editor deny closed statuses for new bugs
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit
-rw-r--r--editworkflow.cgi2
-rw-r--r--template/en/default/admin/workflow/edit.html.tmpl2
2 files changed, 2 insertions, 2 deletions
diff --git a/editworkflow.cgi b/editworkflow.cgi
index eddf845f2..7e51798fc 100644
--- a/editworkflow.cgi
+++ b/editworkflow.cgi
@@ -87,7 +87,7 @@ elsif ($action eq 'update') {
# Part 1: Initial bug statuses.
foreach my $new (@$statuses) {
- if ($cgi->param('w_0_' . $new->id)) {
+ if ($new->is_open && $cgi->param('w_0_' . $new->id)) {
$sth_insert->execute(undef, $new->id)
unless defined $workflow->{0}->{$new->id};
}
diff --git a/template/en/default/admin/workflow/edit.html.tmpl b/template/en/default/admin/workflow/edit.html.tmpl
index 5ae2cef2a..516d184b9 100644
--- a/template/en/default/admin/workflow/edit.html.tmpl
+++ b/template/en/default/admin/workflow/edit.html.tmpl
@@ -67,7 +67,7 @@
</th>
[% FOREACH new_status = statuses %]
- [% IF status.id != new_status.id %]
+ [% IF status.id != new_status.id && (status.id || new_status.is_open) %]
[% checked = workflow.${status.id}.${new_status.id}.defined ? 1 : 0 %]
[% mandatory = (status.id && new_status.name == Param("duplicate_or_move_bug_status")) ? 1 : 0 %]
<td align="center" class="checkbox-cell[% " checked" IF checked || mandatory %]"