diff options
| author | lpsolit%gmail.com <> | 2007-10-09 20:05:58 +0200 |
|---|---|---|
| committer | lpsolit%gmail.com <> | 2007-10-09 20:05:58 +0200 |
| commit | a81a0804496d263f9de71b03e2ebf612e3c534cc (patch) | |
| tree | adaffee611017c7a2b0a6335ab9eb2e774e8a95c /Bugzilla/Attachment.pm | |
| parent | 4f4d96be9d33570d60da58a17b1da0d9d52bbe27 (diff) | |
| download | bugzilla-a81a0804496d263f9de71b03e2ebf612e3c534cc.tar.gz bugzilla-a81a0804496d263f9de71b03e2ebf612e3c534cc.tar.xz | |
Midair with product change while adding an attachment silently clears flags - Patch by Tiago R. Mello <timello@gmail.com> r/a=LpSolit
Diffstat (limited to 'Bugzilla/Attachment.pm')
| -rw-r--r-- | Bugzilla/Attachment.pm | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/Bugzilla/Attachment.pm b/Bugzilla/Attachment.pm index 736959b2f..cc3e16893 100644 --- a/Bugzilla/Attachment.pm +++ b/Bugzilla/Attachment.pm @@ -484,7 +484,7 @@ sub _validate_data { my $imgdata = $img->ImageToBlob(); $data = $imgdata; $cgi->param('contenttype', 'image/png'); - $$hr_vars->{'convertedbmp'} = 1; + $hr_vars->{'convertedbmp'} = 1; } # Make sure the attachment does not exceed the maximum permitted size @@ -810,12 +810,12 @@ sub insert_attachment_for_bug { '^requestee(_type)?-(\d+)$' => { 'type' => 'multi' }, }, MATCH_SKIP_CONFIRM); - $$hr_vars->{'match_field'} = 'requestee'; + $hr_vars->{'match_field'} = 'requestee'; if ($match_status == USER_MATCH_FAILED) { - $$hr_vars->{'message'} = 'user_match_failed'; + $hr_vars->{'message'} = 'user_match_failed'; } elsif ($match_status == USER_MATCH_MULTIPLE) { - $$hr_vars->{'message'} = 'user_match_multiple'; + $hr_vars->{'message'} = 'user_match_multiple'; } # Escape characters in strings that will be used in SQL statements. @@ -902,12 +902,12 @@ sub insert_attachment_for_bug { Bugzilla->error_mode(ERROR_MODE_DIE); eval { Bugzilla::Flag::validate($cgi, $bug->bug_id, -1, SKIP_REQUESTEE_ON_ERROR); - Bugzilla::Flag::process($bug, $attachment, $timestamp, $cgi); + Bugzilla::Flag::process($bug, $attachment, $timestamp, $cgi, $hr_vars); }; Bugzilla->error_mode($error_mode_cache); if ($@) { - $$hr_vars->{'message'} = 'flag_creation_failed'; - $$hr_vars->{'flag_creation_error'} = $@; + $hr_vars->{'message'} = 'flag_creation_failed'; + $hr_vars->{'flag_creation_error'} = $@; } # Return the new attachment object. |