summaryrefslogtreecommitdiffstats
path: root/Bugzilla/Bug.pm
diff options
context:
space:
mode:
authorFrédéric Buclin <LpSolit@gmail.com>2013-10-14 14:44:24 +0200
committerFrédéric Buclin <LpSolit@gmail.com>2013-10-14 14:44:24 +0200
commit5ab9af110e4bb7fc406b2cdcf97fd22cb265b592 (patch)
tree3af7c2c376ace9213349063cc9d735fb8615d7fc /Bugzilla/Bug.pm
parentc88c3c0a5582284e5f72252b4742eebb5a1c895a (diff)
downloadbugzilla-5ab9af110e4bb7fc406b2cdcf97fd22cb265b592.tar.gz
bugzilla-5ab9af110e4bb7fc406b2cdcf97fd22cb265b592.tar.xz
Backout 1st part of bug 340160: state $sth doesn't work fine with mod_perl
Diffstat (limited to 'Bugzilla/Bug.pm')
-rw-r--r--Bugzilla/Bug.pm11
1 files changed, 5 insertions, 6 deletions
diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index 2c0d458e7..61731c039 100644
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -3954,11 +3954,7 @@ sub get_activity {
# Update the bugs_activity table to reflect changes made in bugs.
sub LogActivityEntry {
my ($i, $col, $removed, $added, $whoid, $timestamp, $comment_id) = @_;
- state $sth =
- Bugzilla->dbh->prepare('INSERT INTO bugs_activity
- (bug_id, who, bug_when, fieldid, removed, added, comment_id)
- VALUES (?, ?, ?, ?, ?, ?, ?)');
-
+ my $dbh = Bugzilla->dbh;
# in the case of CCs, deps, and keywords, there's a possibility that someone
# might try to add or remove a lot of them at once, which might take more
# space than the activity table allows. We'll solve this by splitting it
@@ -3982,7 +3978,10 @@ sub LogActivityEntry {
trick_taint($addstr);
trick_taint($removestr);
my $fieldid = get_field_id($col);
- $sth->execute($i, $whoid, $timestamp, $fieldid, $removestr, $addstr, $comment_id);
+ $dbh->do("INSERT INTO bugs_activity
+ (bug_id, who, bug_when, fieldid, removed, added, comment_id)
+ VALUES (?, ?, ?, ?, ?, ?, ?)",
+ undef, ($i, $whoid, $timestamp, $fieldid, $removestr, $addstr, $comment_id));
}
}