Bug 364286: Code in Classification->products() is suboptimal - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave

1 files changed, 2 insertions, 6 deletions

diff --git a/Bugzilla/Classification.pm b/Bugzilla/Classification.pm
index 3d264b704..37ae3a0cc 100644
--- a/Bugzilla/Classification.pm
+++ b/Bugzilla/Classification.pm
@@ -106,12 +106,8 @@ sub products {
             SELECT id FROM products
             WHERE classification_id = ?
             ORDER BY name}, undef, $self->id);
- 
-        my @products;
-        foreach my $product_id (@$product_ids) {
-            push (@products, new Bugzilla::Product($product_id));
-        }
-        $self->{'products'} = \@products;
+
+        $self->{'products'} = Bugzilla::Product->new_from_list($product_ids);
     }
     return $self->{'products'};
 }