diff options
| author | jouni%heikniemi.net <> | 2004-07-20 14:08:26 +0200 |
|---|---|---|
| committer | jouni%heikniemi.net <> | 2004-07-20 14:08:26 +0200 |
| commit | 8832bf88d9c7720750dc5ae1f75f50e1b6e8c89c (patch) | |
| tree | a6e764470e174f2d2ca4b29a7497fce1c39242a9 /Bugzilla/FlagType.pm | |
| parent | 0ed8d17388e304fe1d32f78d71a88597929236e5 (diff) | |
| download | bugzilla-8832bf88d9c7720750dc5ae1f75f50e1b6e8c89c.tar.gz bugzilla-8832bf88d9c7720750dc5ae1f75f50e1b6e8c89c.tar.xz | |
Bug 250547: Make FlagTypes use INNER JOIN instead of comma operator.
Patch by Tomas Kopal <Tomas.Kopal@altap.cz>
r=jouni, a=justdave
Diffstat (limited to 'Bugzilla/FlagType.pm')
| -rw-r--r-- | Bugzilla/FlagType.pm | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Bugzilla/FlagType.pm b/Bugzilla/FlagType.pm index a428d5389..f1cb00c5d 100644 --- a/Bugzilla/FlagType.pm +++ b/Bugzilla/FlagType.pm @@ -326,8 +326,8 @@ sub sqlify_criteria { # Add inclusions to the query, which simply involves joining the table # by flag type ID and target product/component. - push(@$tables, ", flaginclusions"); - push(@criteria, "flagtypes.id = flaginclusions.type_id"); + push(@$tables, "INNER JOIN flaginclusions ON " . + "flagtypes.id = flaginclusions.type_id"); push(@criteria, "(flaginclusions.product_id = $product_id " . " OR flaginclusions.product_id IS NULL)"); push(@criteria, "(flaginclusions.component_id = $component_id " . |