summaryrefslogtreecommitdiffstats
path: root/Bugzilla
diff options
context:
space:
mode:
authorlpsolit%gmail.com <>2009-04-06 22:02:51 +0200
committerlpsolit%gmail.com <>2009-04-06 22:02:51 +0200
commit1633d9835c4ab45d583ba4b6d8b585d66925a5b2 (patch)
treea59da1c5899387fc43a553a41810e2fe4aea1bc4 /Bugzilla
parent2ee6d9a1b8ebde208a1ff11e97c909925fe87303 (diff)
downloadbugzilla-1633d9835c4ab45d583ba4b6d8b585d66925a5b2.tar.gz
bugzilla-1633d9835c4ab45d583ba4b6d8b585d66925a5b2.tar.xz
Bug 486881: A powerless user can still see a restricted bug when he removes all his roles related to the bug - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
Diffstat (limited to 'Bugzilla')
-rw-r--r--Bugzilla/Bug.pm4
-rw-r--r--Bugzilla/User.pm2
2 files changed, 6 insertions, 0 deletions
diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index 5038275c8..79cf1dd5e 100644
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -876,6 +876,10 @@ sub update {
delete $self->{'_old_assigned_to'};
delete $self->{'_old_qa_contact'};
+ # Also flush the visible_bugs cache for this bug as the user's
+ # relationship with this bug may have changed.
+ delete Bugzilla->user->{_visible_bugs_cache}->{$self->id};
+
return $changes;
}
diff --git a/Bugzilla/User.pm b/Bugzilla/User.pm
index 74289fe56..cf4cb5fa6 100644
--- a/Bugzilla/User.pm
+++ b/Bugzilla/User.pm
@@ -588,6 +588,8 @@ sub visible_bugs {
# We only check the visibility of bugs that we haven't
# checked yet.
+ # Bugzilla::Bug->update automatically removes updated bugs
+ # from the cache to force them to be checked again.
my $visible_cache = $self->{_visible_bugs_cache} ||= {};
my @check_ids = grep(!exists $visible_cache->{$_}, @bug_ids);