summaryrefslogtreecommitdiffstats
path: root/Bugzilla
diff options
context:
space:
mode:
authorFrédéric Buclin <LpSolit@gmail.com>2010-02-01 22:19:31 +0100
committerMax Kanat-Alexander <mkanat@bugzilla.org>2010-02-01 22:19:31 +0100
commit6d11d68f570d4d921f078a67ce1928703df4bf2e (patch)
treec97a1429bde0a22dfbee73a9900d663d43692b00 /Bugzilla
parentd80ce7526c14db8737febb824347c1ee09af2707 (diff)
downloadbugzilla-6d11d68f570d4d921f078a67ce1928703df4bf2e.tar.gz
bugzilla-6d11d68f570d4d921f078a67ce1928703df4bf2e.tar.xz
Bug 532493: [SECURITY] Restricting a bug to a group while moving it to another product has no effect if the group is not used by both products
Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=LpSolit
Diffstat (limited to 'Bugzilla')
-rw-r--r--Bugzilla/Bug.pm27
1 files changed, 0 insertions, 27 deletions
diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index 1eaafb698..fd28b5b82 100644
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -643,33 +643,6 @@ sub run_create_validators {
return $params;
}
-sub set_all {
- my ($self, $args) = @_;
-
- # For security purposes, and because lots of other checks depend on it,
- # we set the product first before anything else.
- my $product_change = 0;
- if ($args->{product}) {
- my $changed = $self->set_product($args->{product},
- { component => $args->{component},
- version => $args->{version},
- target_milestone => $args->{target_milestone},
- change_confirmed => $args->{confirm_product_change},
- other_bugs => $args->{other_bugs},
- });
- # that will be used later to check strict isolation
- $product_change = $changed;
- }
-
- # add/remove groups
- $self->remove_group($_) foreach @{$args->{remove_group}};
- $self->add_group($_) foreach @{$args->{add_group}};
-
- # this is temporary until all related code is moved from
- # process_bug.cgi to set_all
- return $product_change;
-}
-
sub update {
my $self = shift;