Bug 286235: Implicit joins should be replaced by explicit joins - installment A

Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk

1 files changed, 4 insertions, 3 deletions

diff --git a/editmilestones.cgi b/editmilestones.cgi
index 0edbd1897..796643e9e 100755
--- a/editmilestones.cgi
+++ b/editmilestones.cgi
@@ -79,9 +79,10 @@ sub TestMilestone ($$)
     # does the product exist?
     my $sth = $dbh->prepare_cached("
              SELECT products.name, value
-             FROM milestones, products
-             WHERE milestones.product_id = products.id
-               AND products.name = ?
+             FROM milestones
+             INNER JOIN products
+                ON milestones.product_id = products.id
+             WHERE products.name = ?
                AND value = ?");
 
     trick_taint($product);