summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLukas Fleischer <archlinux@cryptocrack.de>2011-08-24 10:18:27 +0200
committerPierre Schmitz <pierre@archlinux.de>2011-08-25 11:21:24 +0200
commit7020d2351bb3468d6b0d32ad5908b9b475ae274c (patch)
tree3840ad184a6e68fb4e9e2283b77c8a3f886cc77b
parent7952d6fbfc4f6430e043d65ddf2923ca359cfb73 (diff)
downloaddevtools-7020d2351bb3468d6b0d32ad5908b9b475ae274c.tar.gz
devtools-7020d2351bb3468d6b0d32ad5908b9b475ae274c.tar.xz
checkpkg: Use read builtin to get new ".so" files
The read shell builtin is the proper way to read single lines. Also, simplify grep(1) and awk(1) invocations and use a single awk(1) expression, that supports extracting file names with spaces, instead. Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de> Signed-off-by: Pierre Schmitz <pierre@archlinux.de>
-rwxr-xr-xcheckpkg2
1 files changed, 1 insertions, 1 deletions
diff --git a/checkpkg b/checkpkg
index f408267..2f442c9 100755
--- a/checkpkg
+++ b/checkpkg
@@ -81,7 +81,7 @@ for _pkgname in "${pkgname[@]}"; do
mkdir -p pkg
cd pkg
bsdtar xf ../"$pkgfile" > /dev/null
- for i in $(diff "../filelist-$_pkgname-old" "../filelist-$_pkgname" | grep \> | grep '\.so' | awk '{print $2}'); do
+ diff "../filelist-$_pkgname-old" "../filelist-$_pkgname" | awk '/>.*\.so/{$1 = ""; print $0}' | while read i; do
echo "${i}: " "$(objdump -p "$i" | grep SONAME)"
done
cd ..